fix(AchievementsRelationManager): gracefully handle bulk re-inserts of trashed credit #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't figure out how to do that. I can edit the credit record, but there's no delete option. |
|
Interesting! Here is what I see: Brave.Browser.mp4Could be perms-related? public function delete(User $user, AchievementAuthor $achievementAuthor): bool
{
return $user->hasAnyRole([
Role::MODERATOR,
Role::TEAM_ACCOUNT,
]);
} |
|
Yep. I didn't think to try "Moderator". I tried "Developer", "Game Editor" and "Admin". |
Jamiras
approved these changes
Feb 3, 2025
|
Strange, I am able to reproduce that issue for either the relation manager or the bulk add tool: Brave.Browser.mp4Possible I am doing something wrong? Going to go ahead and merge this, but happy to hunt down a bug in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://discord.com/channels/476211979464343552/1026595325038833725/1335738485273002056.
Currently, a server error is thrown when trying to re-insert a soft deleted credit record using this tool:
Steps to repro the server error:
Now, similar to
AuthorshipCreditsRelationManager, if we're reinserting a trashed record, we'll restore it.